drm/nouveau: fix stale locked mutex in nouveau_gem_ioctl_pushbuf
authorKarol Herbst <kherbst@redhat.com>
Tue, 5 Mar 2024 13:38:52 +0000 (14:38 +0100)
committerKarol Herbst <kherbst@redhat.com>
Tue, 5 Mar 2024 13:59:38 +0000 (14:59 +0100)
commitdaf8739c3322a762ce84f240f50e0c39181a41ab
tree6f172fcd576a7cb308226e4c3ebf4613f97c29d1
parent9dfc46c87cdc8f5a42a71de247a744a6b8188980
drm/nouveau: fix stale locked mutex in nouveau_gem_ioctl_pushbuf

If VM_BIND is enabled on the client the legacy submission ioctl can't be
used, however if a client tries to do so regardless it will return an
error. In this case the clients mutex remained unlocked leading to a
deadlock inside nouveau_drm_postclose or any other nouveau ioctl call.

Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: <stable@vger.kernel.org> # v6.6+
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240305133853.2214268-1-kherbst@redhat.com
drivers/gpu/drm/nouveau/nouveau_gem.c