drm/ttm: fix locking in vmap/vunmap TTM GEM helpers
authorChristian König <christian.koenig@amd.com>
Fri, 15 Jul 2022 07:57:22 +0000 (09:57 +0200)
committerChristian König <christian.koenig@amd.com>
Mon, 18 Jul 2022 07:18:53 +0000 (09:18 +0200)
commitdbd0da2453c694f2f74651834d90fb280b57f151
tree0118d6aa78d7d7425ef58a031f45344e32f7cde8
parent9b04369b060fd4885f728b7a4ab4851ffb1abb64
drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

I've stumbled over this while reviewing patches for DMA-buf and it looks
like we completely messed the locking up here.

In general most TTM function should only be called while holding the
appropriate BO resv lock. Without this we could break the internal
buffer object state here.

Only compile tested!

Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: 43676605f890 ("drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers")
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220715111533.467012-1-christian.koenig@amd.com
drivers/gpu/drm/drm_gem_ttm_helper.c