s390-ccw: set cp_receive mask only when needed and consume pending service irqs
authorCollin L. Walling <walling@linux.vnet.ibm.com>
Fri, 23 Feb 2018 15:43:17 +0000 (10:43 -0500)
committerThomas Huth <thuth@redhat.com>
Mon, 26 Feb 2018 06:56:55 +0000 (07:56 +0100)
commitdbf2091aba8abc312dbab931b12ebc4ff213ffd6
tree26846f90af29617a2a8ae34cdb700e2f59bb6ad9
parentff5dbf1bc3b81248f4f1c253b586491bc8daeda5
s390-ccw: set cp_receive mask only when needed and consume pending service irqs

It is possible while waiting for multiple types of external
interrupts that we might have pending irqs remaining between
irq consumption and irq-type disabling. Those interrupts
could potentially propagate to the guest after IPL completes
and cause unwanted behavior.

As it is today, the SCLP will only recognize write events that
are enabled by the control program's send and receive masks. To
limit the window for, and prevent further irqs from, ASCII
console events (specifically keystrokes), we should only enable
the control program's receive mask when we need it.

While we're at it, remove assignment of the (non control program)
send and receive masks, as those are actually set by the SCLP.

Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/menu.c
pc-bios/s390-ccw/s390-ccw.h
pc-bios/s390-ccw/sclp.c