ASoC: core: Do not call link_exit() on uninitialized rtd objects
authorAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Fri, 29 Sep 2023 10:32:43 +0000 (12:32 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 29 Sep 2023 12:17:49 +0000 (14:17 +0200)
commitdd9f9cc1e6b9391140afa5cf27bb47c9e2a08d02
tree234e190c79d6e8295713e620a0cc7f68b7ee4cab
parente80f238d2bc0c0f27dc52ac824ca80b938a43ace
ASoC: core: Do not call link_exit() on uninitialized rtd objects

On init we have sequence:

for_each_card_prelinks(card, i, dai_link) {
ret = snd_soc_add_pcm_runtime(card, dai_link);

ret = init_some_other_things(...);
if (ret)
goto probe_end:

for_each_card_rtds(card, rtd) {
ret = soc_init_pcm_runtime(card, rtd);

probe_end:

while on exit:
for_each_card_rtds(card, rtd)
snd_soc_link_exit(rtd);

If init_some_other_things() step fails due to error we end up with
not fully setup rtds and try to call snd_soc_link_exit on them, which
depending on contents on .link_exit handler, can end up dereferencing
NULL pointer.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230929103243.705433-2-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc.h
sound/soc/soc-core.c