x86/cacheinfo: Remove unneeded dead-store initialization
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 31 Mar 2021 08:00:24 +0000 (16:00 +0800)
committerBorislav Petkov <bp@suse.de>
Wed, 7 Apr 2021 19:12:12 +0000 (21:12 +0200)
commitdda451f391eee5d68db3ca87fd8b2a42c8c2b507
tree7c8ac35543a1ba86f9a00e472ada967cd1cc4b35
parent1591584e2e762edecefde403c44d9c26c9ff72c9
x86/cacheinfo: Remove unneeded dead-store initialization

$ make CC=clang clang-analyzer

(needs clang-tidy installed on the system too)

on x86_64 defconfig triggers:

  arch/x86/kernel/cpu/cacheinfo.c:880:24: warning: Value stored to 'this_cpu_ci' \
  during its initialization is never read [clang-analyzer-deadcode.DeadStores]
        struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
                              ^
  arch/x86/kernel/cpu/cacheinfo.c:880:24: note: Value stored to 'this_cpu_ci' \
during its initialization is never read

So simply remove this unneeded dead-store initialization.

As compilers will detect this unneeded assignment and optimize this
anyway the resulting object code is identical before and after this
change.

No functional change. No change to object code.

 [ bp: Massage commit message. ]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lkml.kernel.org/r/1617177624-24670-1-git-send-email-yang.lee@linux.alibaba.com
arch/x86/kernel/cpu/cacheinfo.c