bpf: Do not invoke the XDP dispatcher for PROG_RUN with single repeat
authorLorenz Bauer <lmb@cloudflare.com>
Tue, 28 Sep 2021 09:30:59 +0000 (10:30 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 29 Sep 2021 21:10:05 +0000 (14:10 -0700)
commitde21d8bf777240c6d6dfefa39b4925729e32c0fd
treea62f83fdc7bfe7b37db6455234c9992a31136834
parent66fe33241726d1f872e55d95a35c063d58602ae1
bpf: Do not invoke the XDP dispatcher for PROG_RUN with single repeat

We have a unit test that invokes an XDP program with 1m different
inputs, aka 1m BPF_PROG_RUN syscalls. We run this test concurrently
with slight variations in how we generated the input.

Since commit f23c4b3924d2 ("bpf: Start using the BPF dispatcher in BPF_TEST_RUN")
the unit test has slowed down significantly. Digging deeper reveals that
the concurrent tests are serialised in the kernel on the XDP dispatcher.
This is a global resource that is protected by a mutex, on which we contend.

Fix this by not calling into the XDP dispatcher if we only want to perform
a single run of the BPF program.

See: https://lore.kernel.org/bpf/CACAyw9_y4QumOW35qpgTbLsJ532uGq-kVW-VESJzGyiZkypnvw@mail.gmail.com/

Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210928093100.27124-1-lmb@cloudflare.com
net/bpf/test_run.c