hostmem: Don't report pmem attribute if unsupported
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 26 Jan 2021 07:48:25 +0000 (08:48 +0100)
committerEduardo Habkost <ehabkost@redhat.com>
Thu, 18 Feb 2021 23:34:47 +0000 (18:34 -0500)
commitdef835f0da0d153b397071e6bb8f2b46f51f96b4
tree090f945eec21f203585aa44247977a73f13658fc
parent1a14d4e16af96d6b390da30a9ac707a84b70cbfc
hostmem: Don't report pmem attribute if unsupported

When management applications (like Libvirt) want to check whether
memory-backend-file.pmem is supported they can list object
properties using 'qom-list-properties'. However, 'pmem' is
declared always (and thus reported always) and only at runtime
QEMU errors out if it was built without libpmem (and thus can not
guarantee write persistence). This is suboptimal since we have
ability to declare attributes at compile time.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1915216
Message-Id: <dfcc5dc7e2efc0283bc38e3036da2c0323621cdb.1611647111.git.mprivozn@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
backends/hostmem-file.c