firmware: raspberrypi: Use correct device for DMA mappings
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 26 Mar 2024 19:58:06 +0000 (21:58 +0200)
committerFlorian Fainelli <florian.fainelli@broadcom.com>
Thu, 4 Apr 2024 16:49:20 +0000 (09:49 -0700)
commitdf518a0ae1b982a4dcf2235464016c0c4576a34d
treedf2ddd3953d6e25baf035be6157e0501336cb2a6
parent2604f31693c886aacf41758b7bac2dd481673ad8
firmware: raspberrypi: Use correct device for DMA mappings

The buffer used to transfer data over the mailbox interface is mapped
using the client's device. This is incorrect, as the device performing
the DMA transfer is the mailbox itself. Fix it by using the mailbox
controller device instead.

This requires including the mailbox_controller.h header to dereference
the mbox_chan and mbox_controller structures. The header is not meant to
be included by clients. This could be fixed by extending the client API
with a function to access the controller's device.

Fixes: 4e3d60656a72 ("ARM: bcm2835: Add the Raspberry Pi firmware driver")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Tested-by: Ivan T. Ivanov <iivanov@suse.de>
Link: https://lore.kernel.org/r/20240326195807.15163-3-laurent.pinchart@ideasonboard.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
drivers/firmware/raspberrypi.c