cpus: Make {start,end}_exclusive() recursive
authorIlya Leoshkevich <iii@linux.ibm.com>
Tue, 14 Feb 2023 14:08:27 +0000 (15:08 +0100)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 21 Feb 2023 18:44:13 +0000 (08:44 -1000)
commitdf8a688032280ecd07ace7c6fbc70f5650cca9af
tree1bd5deeda135d8a288d0c822e6619425831b120f
parent7de0816f699553514016f52a76e26d1c2ae14034
cpus: Make {start,end}_exclusive() recursive

Currently dying to one of the core_dump_signal()s deadlocks, because
dump_core_and_abort() calls start_exclusive() two times: first via
stop_all_tasks(), and then via preexit_cleanup() ->
qemu_plugin_user_exit().

There are a number of ways to solve this: resume after dumping core;
check cpu_in_exclusive_context() in qemu_plugin_user_exit(); or make
{start,end}_exclusive() recursive. Pick the last option, since it's
the most straightforward one.

Fixes: da91c1920242 ("linux-user: Clean up when exiting due to a signal")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230214140829.45392-3-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
cpus-common.c
include/hw/core/cpu.h