KVM: selftests: Load RAX with -EFAULT before Hyper-V hypercall
authorVipin Sharma <vipinsh@google.com>
Thu, 22 Sep 2022 06:24:51 +0000 (23:24 -0700)
committerSean Christopherson <seanjc@google.com>
Wed, 28 Sep 2022 19:47:19 +0000 (12:47 -0700)
commitdfb45db43e9f6283a79230c8ea9cb589f14791b0
tree17287a356e4a8301a239b7e1d341c23a03080b4b
parentbf3f11581893494a5fb01eb87b99627edc2a85ff
KVM: selftests: Load RAX with -EFAULT before Hyper-V hypercall

Load RAX with -EFAULT prior to making a Hyper-V hypercall so that tests
can't get false negatives due to the compiler coincidentally loading the
"right" value into RAX, i.e. to ensure that _KVM_ and not the compiler
is correctly clearing RAX on a successful hypercall.

Note, initializing *hv_status (in C code) to -EFAULT is not sufficient
to avoid false negatives, as the compiler can still "clobber" RAX and
thus load garbage into *hv_status if the hypercall faults (or if KVM
doesn't set RAX).

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Vipin Sharma <vipinsh@google.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Link: https://lore.kernel.org/r/20220922062451.2927010-1-vipinsh@google.com
[sean: move to separate patch, massage changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
tools/testing/selftests/kvm/x86_64/hyperv_features.c