memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]
authorColin Ian King <colin.king@canonical.com>
Tue, 23 Feb 2021 19:38:21 +0000 (19:38 +0000)
committerKrzysztof Kozlowski <krzk@kernel.org>
Sun, 7 Mar 2021 19:55:00 +0000 (20:55 +0100)
commite004c3e67b6459c99285b18366a71af467d869f5
treeb2ef0f709f7aabb255a5982e0f09b95a00d60b9d
parenta38fd8748464831584a19438cbb3082b5a2dab15
memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

Currently the array gpmc_cs is indexed by cs before it cs is range checked
and the pointer read from this out-of-index read is dereferenced. Fix this
by performing the range check on cs before the read and the following
pointer dereference.

Addresses-Coverity: ("Negative array index read")
Fixes: 9ed7a776eb50 ("ARM: OMAP2+: Fix support for multiple devices on a GPMC chip select")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20210223193821.17232-1-colin.king@canonical.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/memory/omap-gpmc.c