clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe
authorZhanhao Hu <zero12113@hust.edu.cn>
Thu, 1 Jun 2023 03:38:25 +0000 (03:38 +0000)
committerAbel Vesa <abel.vesa@linaro.org>
Mon, 12 Jun 2023 09:18:56 +0000 (12:18 +0300)
commite02ba11b457647050cb16e7cad16cec3c252fade
treeab1a5961948bc91c6dc6afcaf4aa93612e929529
parent188d070de9132667956f5aadd98d2bd87d3eac89
clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe

In function probe(), it returns directly without unregistered hws
when error occurs.

Fix this by adding 'goto unregister_hws;' on line 295 and
line 310.

Use devm_kzalloc() instead of kzalloc() to automatically
free the memory using devm_kfree() when error occurs.

Replace of_iomap() with devm_of_iomap() to automatically
handle the unused ioremap region and delete 'iounmap(anatop_base);'
in unregister_hws.

Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
Signed-off-by: Zhanhao Hu <zero12113@hust.edu.cn>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230601033825.336558-1-zero12113@hust.edu.cn
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
drivers/clk/imx/clk-imx93.c