mm: fix arithmetic for bdi min_ratio
authorJingbo Xu <jefflexu@linux.alibaba.com>
Tue, 19 Dec 2023 14:25:07 +0000 (22:25 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 29 Dec 2023 19:06:47 +0000 (11:06 -0800)
commite0646b7590084a5bf3b056d3ad871d9379d2c25a
tree7dd7c742f1943c2b36df9c444d7ba5a5167679a0
parentefa7df3e3bb5da8e6abbe37727417f32a37fba47
mm: fix arithmetic for bdi min_ratio

Since now bdi->min_ratio is part per million, fix the wrong arithmetic.
Otherwise it will fail with -EINVAL when setting a reasonable min_ratio,
as it tries to set min_ratio to (min_ratio * BDI_RATIO_SCALE) in
percentage unit, which exceeds 100% anyway.

    # cat /sys/class/bdi/253\:0/min_ratio
    0
    # cat /sys/class/bdi/253\:0/max_ratio
    100
    # echo 1 > /sys/class/bdi/253\:0/min_ratio
    -bash: echo: write error: Invalid argument

Link: https://lkml.kernel.org/r/20231219142508.86265-2-jefflexu@linux.alibaba.com
Fixes: 8021fb3232f2 ("mm: split off __bdi_set_min_ratio() function")
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reported-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Stefan Roesch <shr@devkernel.io>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page-writeback.c