wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap()
authorMahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Tue, 15 Aug 2023 04:08:19 +0000 (08:08 +0400)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 23 Aug 2023 14:16:14 +0000 (17:16 +0300)
commite10ec6ea612ca54e3266996875b0742619dac20f
tree38bef5b7c3b60d32cf1a419debf0c3b822c6fb3d
parent3b86f86d0f163454c4043a629f0ba95641d371bc
wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap()

coccinielle reported the following:
./drivers/net/wireless/ath/ath5k/phy.c:1573:25-26: WARNING opportunity for swap()

while trying to fix the above warning, it reveals that ath5k_hw_get_median_noise_floor()
had open-coded sort() functionality. Since ath5k_hw_get_median_noise_floor() only
executes once every 10 seconds, any extra overhead due to sort() calling
its "compare" and "swap" functions can be ignored, so replace the
existing logic with a call to sort().

Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Suggested-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230815040819.649455-1-mahmoudmatook.mm@gmail.com
drivers/net/wireless/ath/ath5k/phy.c