selftests:breakpoints: Fix Format String Warning in breakpoint_test
authorangquan yu <angquan21@gmail.com>
Wed, 29 Nov 2023 03:57:26 +0000 (21:57 -0600)
committerShuah Khan <skhan@linuxfoundation.org>
Thu, 30 Nov 2023 21:32:28 +0000 (14:32 -0700)
commite1c0b9ef26e5e46fd5c2df9e7f9686e786723f53
treec29d35fda98d73f369db3b3836aace42679783c0
parentb85ea95d086471afb4ad062012a4d73cd328fa86
selftests:breakpoints: Fix Format String Warning in breakpoint_test

This commit resolves a compiler warning regardingthe
use of non-literal format strings in breakpoint_test.c.

The functions `ksft_test_result_pass` and `ksft_test_result_fail`
were previously called with a variable `msg` directly, which could
potentially lead to format string vulnerabilities.

Changes made:
- Modified the calls to `ksft_test_result_pass` and `ksft_test_result_fail`
by adding a "%s" format specifier. This explicitly declares `msg` as a
string argument, adhering to safer coding practices and resolving
the compiler warning.

This change does not affect the functional behavior of the code but ensures
better code safety and compliance with recommended C programming standards.

The previous warning is "breakpoint_test.c:287:17:
warning: format not a string literal and no format arguments
[-Wformat-security]
  287 |                 ksft_test_result_pass(msg);
      |                 ^~~~~~~~~~~~~~~~~~~~~
breakpoint_test.c:289:17: warning: format not a string literal
and no format arguments [-Wformat-security]
  289 |                 ksft_test_result_fail(msg);
      |    "

Signed-off-by: angquan yu <angquan21@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/breakpoints/breakpoint_test.c