net: sparx5: replace deprecated strncpy with ethtool_sprintf
authorJustin Stitt <justinstitt@google.com>
Wed, 11 Oct 2023 21:37:18 +0000 (21:37 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Oct 2023 00:10:32 +0000 (17:10 -0700)
commite343023e03d2bdadf6551298863c09b4cba5963d
treee9a843b5668aa273509baa7caa0c2fae44d7dc50
parent88fca39b660b97651fbf5ba18074b7999fab98a7
net: sparx5: replace deprecated strncpy with ethtool_sprintf

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy() in favor of this more robust and easier to
understand interface.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20231011-strncpy-drivers-net-ethernet-microchip-sparx5-sparx5_ethtool-c-v1-1-410953d07f42@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c