drm: lcdif: Set and enable FIFO Panic threshold
authorMarek Vasut <marex@denx.de>
Tue, 1 Nov 2022 15:26:29 +0000 (16:26 +0100)
committerMarek Vasut <marex@denx.de>
Wed, 9 Nov 2022 00:31:45 +0000 (01:31 +0100)
commite3cac8f7749f78dacdf19c00ed5862a1db52239f
tree1e3d4cc8a18a140f91b47a1bcf7fb788a4ae7dd1
parent1a0257c352638916fdaffaac2ddedb8e049312f3
drm: lcdif: Set and enable FIFO Panic threshold

In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge,
the LCDIFv3 becomes susceptible to FIFO underflows, these lead to nasty
flicker of the image on the panel, or image being shifted by half frame
horizontally every second frame. The flicker can be easily triggered by
running 3D application on top of weston compositor, like neverball or
chromium. Surprisingly glmark2-es2-wayland or glmark2-es2-drm does not
trigger this effect so easily.

Configure the FIFO Panic threshold register and enable the FIFO Panic
mode, which internally boosts the NoC interconnect priority for LCDIFv3
transactions in case of possible underflow. This mitigates the flicker
effect on 4k panels as well.

Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut <marex@denx.de>
Tested-by: Liu Ying <victor.liu@nxp.com> # i.MX8mp EVK
Reviewed-by: Liu Ying <victor.liu@nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221101152629.21768-1-marex@denx.de
drivers/gpu/drm/mxsfb/lcdif_kms.c
drivers/gpu/drm/mxsfb/lcdif_regs.h