ipv6: drop feature RTAX_FEATURE_ALLFRAG
authorYan Zhai <yan@cloudflare.com>
Tue, 24 Oct 2023 14:26:33 +0000 (07:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 26 Oct 2023 01:04:29 +0000 (18:04 -0700)
commite57a34478586fe3562560ccebd655b707a5b4a56
tree85fd7fa5d3e08af7ccd7769b4e11fa58ccaadd83
parent8846f9a04b10b7f61214425409838d764df7080d
ipv6: drop feature RTAX_FEATURE_ALLFRAG

RTAX_FEATURE_ALLFRAG was added before the first git commit:

https://www.mail-archive.com/bk-commits-head@vger.kernel.org/msg03399.html

The feature would send packets to the fragmentation path if a box
receives a PMTU value with less than 1280 byte. However, since commit
9d289715eb5c ("ipv6: stop sending PTB packets for MTU < 1280"), such
message would be simply discarded. The feature flag is neither supported
in iproute2 utility. In theory one can still manipulate it with direct
netlink message, but it is not ideal because it was based on obsoleted
guidance of RFC-2460 (replaced by RFC-8200).

The feature would always test false at the moment, so remove related
code or mark them as unused.

Signed-off-by: Yan Zhai <yan@cloudflare.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/d78e44dcd9968a252143ffe78460446476a472a1.1698156966.git.yan@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/dst.h
include/net/inet_connection_sock.h
include/net/inet_sock.h
include/uapi/linux/rtnetlink.h
net/ipv4/tcp_output.c
net/ipv6/ip6_output.c
net/ipv6/tcp_ipv6.c
net/ipv6/xfrm6_output.c
net/mptcp/subflow.c