Bluetooth: Acquire sk_lock.slock without disabling interrupts
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 28 May 2020 12:35:12 +0000 (14:35 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 29 May 2020 11:48:46 +0000 (13:48 +0200)
commite6da0edc24eecef2f6964d92fa9044e1821deace
treeae0757198a7e0fc8aca8a8c33d6a1d3f482dd0eb
parent4803c54ca24923a30664bea2a7772db6e7303c51
Bluetooth: Acquire sk_lock.slock without disabling interrupts

There was a lockdep which led to commit
   fad003b6c8e3d ("Bluetooth: Fix inconsistent lock state with RFCOMM")

Lockdep noticed that `sk->sk_lock.slock' was acquired without disabling
the softirq while the lock was also used in softirq context.
Unfortunately the solution back then was to disable interrupts before
acquiring the lock which however made lockdep happy.
It would have been enough to simply disable the softirq. Disabling
interrupts before acquiring a spinlock_t is not allowed on PREEMPT_RT
because these locks are converted to 'sleeping' spinlocks.

Use spin_lock_bh() in order to acquire the `sk_lock.slock'.

Reported-by: Luis Claudio R. Goncalves <lclaudio@uudg.org>
Reported-by: kbuild test robot <lkp@intel.com> [missing unlock]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/rfcomm/sock.c