drm/lima: remove guilty drm_sched context handling
authorErico Nunes <nunes.erico@gmail.com>
Wed, 24 Jan 2024 02:59:45 +0000 (03:59 +0100)
committerQiang Yu <yuq825@gmail.com>
Mon, 12 Feb 2024 08:27:28 +0000 (16:27 +0800)
commite721d1cc8101a26fba22dc9a62309522e15bd0c7
tree620f6aab20057514441fe70b4f878e2f1968ce09
parent53cb55b20208eaa79de63c82795c8d51caa9cfcc
drm/lima: remove guilty drm_sched context handling

Marking the context as guilty currently only makes the application which
hits a single timeout problem to stop its rendering context entirely.
All jobs submitted later are dropped from the guilty context.

Lima runs on fairly underpowered hardware for modern standards and it is
not entirely unreasonable that a rendering job may time out occasionally
due to high system load or too demanding application stack. In this case
it would be generally preferred to report the error but try to keep the
application going.

Other similar embedded GPU drivers don't make use of the guilty context
flag. Now that there are reliability improvements to the lima timeout
recovery handling, drop the guilty contexts to let the application keep
running in this case.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240124025947.2110659-7-nunes.erico@gmail.com
drivers/gpu/drm/lima/lima_ctx.c
drivers/gpu/drm/lima/lima_ctx.h
drivers/gpu/drm/lima/lima_sched.c
drivers/gpu/drm/lima/lima_sched.h