selftests: Declare local variable for pause in fcnal-test.sh
authorDavid Ahern <dsahern@kernel.org>
Tue, 30 Jan 2024 15:43:27 +0000 (08:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Feb 2024 05:14:51 +0000 (21:14 -0800)
commite79027c08302e299571555a9606b751820afa409
tree72fb46a63e9fe498d49a54838039851a8bf23acf
parent567058d398aa97beaec62252fcc3bb78d34fa270
selftests: Declare local variable for pause in fcnal-test.sh

Running fcnal-test.sh script with -P argument is causing test failures:

  $ ./fcnal-test.sh -t ping -P
  TEST: ping out - ns-B IP                                       [ OK ]

  hit enter to continue, 'q' to quit

  fcnal-test.sh: line 106: [: ping: integer expression expected
  TEST: out,                                                     [FAIL]
      expected rc ping; actual rc 0

  hit enter to continue, 'q' to quit

The test functions use local variable 'a' for addresses and
then log_test is also using 'a' without a local declaration.
Fix by declaring a local variable and using 'ans' (for answer)
in the read.

Signed-off-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20240130154327.33848-1-dsahern@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/fcnal-test.sh