serial: 8250_omap: remove wait loop from Errata i202 workaround
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Thu, 13 Oct 2022 11:23:39 +0000 (13:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 02:44:35 +0000 (03:44 +0100)
commite828e56684d61b17317e0cfdef83791fa61cb76b
treeceb21a119b9d64361af570e7c30f84864fb0cb21
parent93810191f5d23652c0b8a1a9b3a4a89d6fd5063e
serial: 8250_omap: remove wait loop from Errata i202 workaround

We were occasionally seeing the "Errata i202: timedout" on an AM335x
board when repeatedly opening and closing a UART connected to an active
sender. As new input may arrive at any time, it is possible to miss the
"RX FIFO empty" condition, forcing the loop to wait until it times out.

Nothing in the i202 Advisory states that such a wait is even necessary;
other FIFO clear functions like serial8250_clear_fifos() do not wait
either. For this reason, it seems safe to remove the wait, fixing the
mentioned issue.

Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver")
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Link: https://lore.kernel.org/r/20221013112339.2540767-1-matthias.schiffer@ew.tq-group.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c