tests/unit/socket-helpers: Don't close(-1)
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 25 Mar 2024 10:41:00 +0000 (10:41 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 25 Mar 2024 10:41:00 +0000 (10:41 +0000)
commite921e00d4ba6840063d69cb637331d0dc4905e4b
tree490d623c664a6904b0066877cc2ba51bff4ee6a7
parent80e9791a93b856ae959cf0efa04cee53390ed000
tests/unit/socket-helpers: Don't close(-1)

In socket_check_afunix_support() we call socket(PF_UNIX, SOCK_STREAM, 0)
to see if it works, but we call close() on the result whether it
worked or not. Only close the fd if the socket() call succeeded.
Spotted by Coverity.

Resolves: Coverity CID 1497481

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20240312183810.557768-3-peter.maydell@linaro.org
tests/unit/socket-helpers.c