wireless: wext-spy: Fix out-of-bounds warning
authorGustavo A. R. Silva <gustavoars@kernel.org>
Thu, 22 Apr 2021 20:00:32 +0000 (15:00 -0500)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 23 Jun 2021 08:57:17 +0000 (10:57 +0200)
commite93bdd78406da9ed01554c51e38b2a02c8ef8025
treeac2c98cb0b11b66171f679d36dd35f4c921f0333
parent38f75922a6905b010f597fc70dbb5db28398728e
wireless: wext-spy: Fix out-of-bounds warning

Fix the following out-of-bounds warning:

net/wireless/wext-spy.c:178:2: warning: 'memcpy' offset [25, 28] from the object at 'threshold' is out of the bounds of referenced subobject 'low' with type 'struct iw_quality' at offset 20 [-Warray-bounds]

The problem is that the original code is trying to copy data into a
couple of struct members adjacent to each other in a single call to
memcpy(). This causes a legitimate compiler warning because memcpy()
overruns the length of &threshold.low and &spydata->spy_thr_low. As
these are just a couple of struct members, fix this by using direct
assignments, instead of memcpy().

This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().

Link: https://github.com/KSPP/linux/issues/109
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210422200032.GA168995@embeddedor
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/wext-spy.c