irqchip/irq-bcm7038-l1: Prefer struct_size over open coded arithmetic
authorErick Archer <erick.archer@gmx.com>
Fri, 9 Feb 2024 18:31:28 +0000 (19:31 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 13 Feb 2024 09:53:15 +0000 (10:53 +0100)
commite955a71f83598a347eb45af5576e7eb6cb5bf285
treef3735ed1de9f291b5aec50c9034ed6ee3ef1959b
parent004c7a6bf43edbd4b092fb6ebba8991d56bc3428
irqchip/irq-bcm7038-l1: Prefer struct_size over open coded arithmetic

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows.

The cpu variable is a pointer to "struct bcm7038_l1_cpu" and this structure
ends in a flexible array:

struct bcm7038_l1_cpu {
void __iomem *map_base;
u32 mask_cache[];
};

The preferred way in the kernel is to use the struct_size() helper to
do the arithmetic instead of the argument "size + count * size" in the
kzalloc() function.

This way, the code is more readable and more safer.

Signed-off-by: Erick Archer <erick.archer@gmx.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20240209183128.10273-1-erick.archer@gmx.com
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
drivers/irqchip/irq-bcm7038-l1.c