clk: Fix clk_core_get NULL dereference
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Sat, 2 Mar 2024 00:52:14 +0000 (00:52 +0000)
committerStephen Boyd <sboyd@kernel.org>
Sat, 9 Mar 2024 00:36:19 +0000 (16:36 -0800)
commite97fe4901e0f59a0bfd524578fe3768f8ca42428
tree3b8a93da522250af04dc9f14df2159efc26e6549
parent6613476e225e090cc9aad49be7fa504e290dd33d
clk: Fix clk_core_get NULL dereference

It is possible for clk_core_get to dereference a NULL in the following
sequence:

clk_core_get()
    of_clk_get_hw_from_clkspec()
        __of_clk_get_hw_from_provider()
            __clk_get_hw()

__clk_get_hw() can return NULL which is dereferenced by clk_core_get() at
hw->core.

Prior to commit dde4eff47c82 ("clk: Look for parents with clkdev based
clk_lookups") the check IS_ERR_OR_NULL() was performed which would have
caught the NULL.

Reading the description of this function it talks about returning NULL but
that cannot be so at the moment.

Update the function to check for hw before dereferencing it and return NULL
if hw is NULL.

Fixes: dde4eff47c82 ("clk: Look for parents with clkdev based clk_lookups")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/r/20240302-linux-next-24-03-01-simple-clock-fixes-v1-1-25f348a5982b@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c