cifs: Fix caching to try to do open O_WRONLY as rdwr on server
authorDavid Howells <dhowells@redhat.com>
Tue, 2 Apr 2024 09:11:35 +0000 (10:11 +0100)
committerSteve French <stfrench@microsoft.com>
Tue, 2 Apr 2024 14:29:55 +0000 (09:29 -0500)
commite9e62243a3e2322cf639f653a0b0a88a76446ce7
tree024278ce7501e2550652340ddb3f7daa1bbb766e
parent24a9799aa8efecd0eb55a75e35f9d8e6400063aa
cifs: Fix caching to try to do open O_WRONLY as rdwr on server

When we're engaged in local caching of a cifs filesystem, we cannot perform
caching of a partially written cache granule unless we can read the rest of
the granule.  This can result in unexpected access errors being reported to
the user.

Fix this by the following: if a file is opened O_WRONLY locally, but the
mount was given the "-o fsc" flag, try first opening the remote file with
GENERIC_READ|GENERIC_WRITE and if that returns -EACCES, try dropping the
GENERIC_READ and doing the open again.  If that last succeeds, invalidate
the cache for that file as for O_DIRECT.

Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Steve French <sfrench@samba.org>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/dir.c
fs/smb/client/file.c
fs/smb/client/fscache.h