projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: afdb3df) | patch
net: hns: fix unsigned comparison to less than zero
authorColin Ian King <colin.king@canonical.com>
Fri, 5 Apr 2019 13:59:16 +0000 (14:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 Apr 2019 01:29:14 +0000 (18:29 -0700)
commitea401685a20b5d631957f024bda86e1f6118eb20
treedbd27dbe36f06f8bb6da5113f8ce4562b01ef9f1tree | snapshot
parentafdb3df2925a240fd6e73ca53fdb885e90da88bacommit | diff
net: hns: fix unsigned comparison to less than zero

Currently mskid is unsigned and hence comparisons with negative
error return values are always false. Fix this by making mskid an
int.

Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem")
Addresses-Coverity: ("Operands don't affect result")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git