iio:humidity:hdc100x Fix alignment and data leak issues
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 7 Jun 2020 15:53:52 +0000 (16:53 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 5 Jul 2020 13:22:48 +0000 (14:22 +0100)
commitea5e7a7bb6205d24371373cd80325db1bc15eded
tree80f277b58543aa8a999c7b621b340204ebbc10da
parent838e00b13bfd4cac8b24df25bfc58e2eb99bcc70
iio:humidity:hdc100x Fix alignment and data leak issues

One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes).  This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here.  We close both issues by
moving to a suitable structure in the iio_priv() data.
This data is allocated with kzalloc so no data can leak apart
from previous readings.

Fixes: 16bf793f86b2 ("iio: humidity: hdc100x: add triggered buffer support for HDC100X")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: <Stable@vger.kernel.org>
drivers/iio/humidity/hdc100x.c