media: cx23885: Fix snd_card_free call on null card pointer
authorColin Ian King <colin.king@canonical.com>
Wed, 4 Aug 2021 08:50:10 +0000 (10:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:29 +0000 (19:16 +0100)
commitead5a141ea2237093c5290103d7953d93c3a859f
treefade2a62a26ea75fb9cc5be0806fe06f4225a713
parent5a225627ba4ab02d258c87940436a39243ce7b29
media: cx23885: Fix snd_card_free call on null card pointer

[ Upstream commit 7266dda2f1dfe151b12ef0c14eb4d4e622fb211c ]

Currently a call to snd_card_new that fails will set card with a NULL
pointer, this causes a null pointer dereference on the error cleanup
path when card it passed to snd_card_free. Fix this by adding a new
error exit path that does not call snd_card_free and exiting via this
new path.

Addresses-Coverity: ("Explicit null dereference")

Fixes: 9e44d63246a9 ("[media] cx23885: Add ALSA support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/pci/cx23885/cx23885-alsa.c