Revert "net: rtnetlink: Enslave device before bringing it up"
authorNicolas Dichtel <nicolas.dichtel@6wind.com>
Mon, 8 Jan 2024 09:41:02 +0000 (10:41 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 12 Jan 2024 00:47:40 +0000 (16:47 -0800)
commitec4ffd100ffb396eca13ebe7d18938ea80f399c3
tree5ccb9e8cf97bca0ec559b5229967db9ecc3bea75
parent8722014311e613244f33952354956a82fa4b0472
Revert "net: rtnetlink: Enslave device before bringing it up"

This reverts commit a4abfa627c3865c37e036bccb681619a50d3d93c.

The patch broke:
> ip link set dummy0 up
> ip link set dummy0 master bond0 down

This last command is useful to be able to enslave an interface with only
one netlink message.

After discussion, there is no good reason to support:
> ip link set dummy0 down
> ip link set dummy0 master bond0 up
because the bond interface already set the slave up when it is up.

Cc: stable@vger.kernel.org
Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20240108094103.2001224-2-nicolas.dichtel@6wind.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/rtnetlink.c