RDMA/srp: Fix error return code in srp_parse_options()
authorWang Yufen <wangyufen@huawei.com>
Fri, 2 Dec 2022 04:00:38 +0000 (12:00 +0800)
committerLeon Romanovsky <leon@kernel.org>
Sun, 4 Dec 2022 13:26:58 +0000 (15:26 +0200)
commited461b30b22c8fa85c25189c14cb89f29595cd14
treefbc9f949136ccde7145563bf881df4a7caec0b1a
parent725349f8ba1e78a146c6ff8f3ee5e2712e517106
RDMA/srp: Fix error return code in srp_parse_options()

In the previous iteration of the while loop, the "ret" may have been
assigned a value of 0, so the error return code -EINVAL may have been
incorrectly set to 0. To fix set valid return code before calling to
goto. Also investigate each case separately as Andy suggessted.

Fixes: e711f968c49c ("IB/srp: replace custom implementation of hex2bin()")
Fixes: 2a174df0c602 ("IB/srp: Use kstrtoull() instead of simple_strtoull()")
Fixes: 19f313438c77 ("IB/srp: Add RDMA/CM support")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1669953638-11747-2-git-send-email-wangyufen@huawei.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/ulp/srp/ib_srp.c