net: dsa: lantiq_gswip: replace deprecated strncpy with ethtool_sprintf
authorJustin Stitt <justinstitt@google.com>
Mon, 9 Oct 2023 18:24:20 +0000 (18:24 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Oct 2023 00:26:04 +0000 (17:26 -0700)
commited9417206de7d306d6f79340fbe4849d3bdfae4e
tree89c4c295a592a55efe1ab741ee158e3f31fe380d
parentac49b992578d366bde19cfb9316d07784e255d2c
net: dsa: lantiq_gswip: replace deprecated strncpy with ethtool_sprintf

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20231009-strncpy-drivers-net-dsa-lantiq_gswip-c-v1-1-d55a986a14cc@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq_gswip.c