iommu/sun50i: Remove IOMMU_DOMAIN_IDENTITY
authorJason Gunthorpe <jgg@nvidia.com>
Mon, 28 Nov 2022 14:06:28 +0000 (10:06 -0400)
committerJoerg Roedel <jroedel@suse.de>
Mon, 5 Dec 2022 10:52:57 +0000 (11:52 +0100)
commitef5bb8e7a7127218f826b9ccdf7508e7a339f4c2
tree41e12c08a07689419bf700d610b9a155b65aa727
parente563cc0c787c85a4d9def0a77078dc5d3f445e3d
iommu/sun50i: Remove IOMMU_DOMAIN_IDENTITY

This driver treats IOMMU_DOMAIN_IDENTITY the same as UNMANAGED, which
cannot possibly be correct.

UNMANAGED domains are required to start out blocking all DMAs. This seems
to be what this driver does as it allocates a first level 'dt' for the IO
page table that is 0 filled.

Thus UNMANAGED looks like a working IO page table, and so IDENTITY must be
a mistake. Remove it.

Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/0-v1-97f0adf27b5e+1f0-s50_identity_jgg@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/sun50i-iommu.c