platform/chrome: cros_typec_switch: Use fwnode* prop check
authorPrashant Malani <pmalani@chromium.org>
Wed, 4 Jan 2023 06:08:44 +0000 (06:08 +0000)
committerPrashant Malani <pmalani@chromium.org>
Tue, 10 Jan 2023 20:47:32 +0000 (20:47 +0000)
commitef9c00dbd383d2b68207cc996caa05c25c7894f5
tree3e1d25f55d40dff69503e333b1c7adefff39f8aa
parent40a9b13a09ef2ec207fec1b328ed796d08e20e54
platform/chrome: cros_typec_switch: Use fwnode* prop check

Using device_property_present() multiple times on an ACPI device
leads to kernel panics on Chromebook systems. This happens when there
is > 1 boolean property in an ACPI device which is created dynamically
by the BIOS as part of SSDT[1] on Chromebook systems

Since fwnode_* can handle simple device tree properties equally
well, switch to using the fwnode_property_present() function
version. This will avoid panics and make the usage consistent
when we introduce a check for the 2nd property in a subsequent patch.

[1] https://wiki.osdev.org/SSDT

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20230104060846.112216-1-pmalani@chromium.org
drivers/platform/chrome/cros_typec_switch.c