net: mhi: Fix unexpected queue wake
authorLoic Poulain <loic.poulain@linaro.org>
Thu, 10 Dec 2020 11:25:07 +0000 (12:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Dec 2020 01:25:56 +0000 (17:25 -0800)
commitefc36d3c344a36fe73cda93c55763058629e0f2c
treedb1a92d6bec64bd45a6e17c843b6ae9e1303dfd7
parent49506a9ba0619b02bcce039e19dc40b432f56b15
net: mhi: Fix unexpected queue wake

This patch checks that MHI queue is not full before waking up the net
queue. This fix sporadic MHI queueing issues in xmit. Indeed xmit and
its symmetric complete callback (ul_callback) can run concurently, it
is then not safe to unconditionnaly waking the queue in the callback
without checking queue fullness.

Fixes: 3ffec6a14f24 ("net: Add mhi-net driver")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Link: https://lore.kernel.org/r/1607599507-5879-1-git-send-email-loic.poulain@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mhi_net.c