net: fman: memac: free mdio device if lynx_pcs_create() fails
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 30 Jan 2023 19:30:51 +0000 (21:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 1 Feb 2023 05:05:09 +0000 (21:05 -0800)
commitefec2e2a722ed609fc7b64feef720fd601633b73
treeeee1b110008d251765fb66893e20d56f591c9e19
parent8f35ae17ef565a605de5f409e04bcd49a55d7646
net: fman: memac: free mdio device if lynx_pcs_create() fails

When memory allocation fails in lynx_pcs_create() and it returns NULL,
there remains a dangling reference to the mdiodev returned by
of_mdio_find_device() which is leaked as soon as memac_pcs_create()
returns empty-handed.

Fixes: a7c2a32e7f22 ("net: fman: memac: Use lynx pcs driver")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Link: https://lore.kernel.org/r/20230130193051.563315-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fman/fman_memac.c