bootconfig: do not put quotes on cmdline items unless necessary
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 12 Apr 2024 16:02:08 +0000 (01:02 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 12 Apr 2024 16:02:08 +0000 (01:02 +0900)
commitefee03a50c2844d78f6fb5e98be1ffd17605dc5b
tree586189e9f9502b7373e47b06b9edb11aa4bb0492
parent46dad3c1e57897ab9228332f03e1c14798d2d3b9
bootconfig: do not put quotes on cmdline items unless necessary

When trying to migrate to using bootconfig to embed the kernel's and
PID1's command line with the kernel image itself, and so allowing
changing that without modifying the bootloader, I noticed that
/proc/cmdline changed from e.g.

  console=ttymxc0,115200n8 cma=128M quiet -- --log-level=notice

to

  console="ttymxc0,115200n8" cma="128M" quiet -- --log-level="notice"

The kernel parameters are parsed just fine, and the quotes are indeed
stripped from the actual argv[] given to PID1. However, the quoting
doesn't really serve any purpose and looks excessive, and might
confuse some (naive) userspace tool trying to parse /proc/cmdline. So
do not quote the value unless it contains whitespace.

Link: https://lore.kernel.org/all/20240308124401.1702046-1-linux@rasmusvillemoes.dk/
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
init/main.c