uml: Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 14 Jun 2023 00:36:04 +0000 (00:36 +0000)
committerKees Cook <keescook@chromium.org>
Tue, 20 Jun 2023 20:35:37 +0000 (13:35 -0700)
commitf0a6b5831cfb17381ada015778448b12c1c6179e
tree301292e964a596828cbbe8b4a3066225b4f8cdd5
parenta5a319ec2c2236bb96d147c16196d2f1f3799301
uml: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230614003604.1021205-1-azeemshaikh38@gmail.com
arch/um/include/shared/user.h
arch/um/os-Linux/drivers/tuntap_user.c