nbd/server: Request TCP_NODELAY
authorEric Blake <eblake@redhat.com>
Tue, 4 Apr 2023 00:40:47 +0000 (19:40 -0500)
committerEric Blake <eblake@redhat.com>
Tue, 4 Apr 2023 13:13:15 +0000 (08:13 -0500)
commitf1426881a827a6d3f31b65616c4a8db1e9e7c45e
tree09331cfb2a8ad67cc10dee0970c258dd05493d0d
parent51a6dc9d394098e8f4141fad869a1ee9585f54f8
nbd/server: Request TCP_NODELAY

Nagle's algorithm adds latency in order to reduce network packet
overhead on small packets.  But when we are already using corking to
merge smaller packets into transactional requests, the extra delay
from TCP defaults just gets in the way (see recent commit bd2cd4a4).

For reference, qemu as an NBD client already requests TCP_NODELAY (see
nbd_connect() in nbd/client-connection.c); as does libnbd as a client
[1], and nbdkit as a server [2].  Furthermore, the NBD spec recommends
the use of TCP_NODELAY [3].

[1] https://gitlab.com/nbdkit/libnbd/-/blob/a48a1142/generator/states-connect.c#L39
[2] https://gitlab.com/nbdkit/nbdkit/-/blob/45b72f5b/server/sockets.c#L430
[3] https://github.com/NetworkBlockDevice/nbd/blob/master/doc/proto.md#protocol-phases

CC: Florian Westphal <fw@strlen.de>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20230404004047.142086-1-eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
nbd/server.c