firmware: xilinx: Fix dereferencing freed memory
authorTejas Patel <tejas.patel@xilinx.com>
Mon, 8 Feb 2021 06:31:23 +0000 (22:31 -0800)
committerMichal Simek <michal.simek@xilinx.com>
Mon, 1 Mar 2021 11:52:07 +0000 (12:52 +0100)
commitf1f21bece82c76a56a96988ec7d51ccc033d8949
treee31c4412a1b516876e11970ecd515bd4d4eebac7
parentfe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
firmware: xilinx: Fix dereferencing freed memory

Fix smatch warning:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove()
error: dereferencing freed memory 'feature_data'

Use hash_for_each_safe for safe removal of hash entry.

Fixes: acfdd18591ea ("firmware: xilinx: Use hash-table for api feature check")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Link: https://lore.kernel.org/r/1612765883-22018-1-git-send-email-rajan.vaja@xilinx.com
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/firmware/xilinx/zynqmp.c