ACPI: OSI: refactor deprecated strncpy()
authorJustin Stitt <justinstitt@google.com>
Mon, 11 Sep 2023 20:36:44 +0000 (20:36 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 21 Sep 2023 18:55:43 +0000 (20:55 +0200)
commitf1fce1cf4509aa0676b363c203b9ab190c1fd8e8
tree7429e70128606f2d224c629536299a8451e23a26
parentce9ecca0238b140b88f43859b211c9fdfd8e5b70
ACPI: OSI: refactor deprecated strncpy()

`strncpy()` is deprecated for use on NUL-terminated destination strings [1].

We know `osi->string` is a NUL-terminated string due to its eventual use
in `acpi_install_interface()` and `acpi_remove_interface()` which expect
a `acpi_string` which has been specifically typedef'd as:
|  typedef char *acpi_string; /* Null terminated ASCII string */

... and which also has other string functions used on it like `strlen`.
Furthermore, padding is not needed in this instance either.

Due to the reasoning above a suitable replacement is `strscpy` [2] since
it guarantees NUL-termination on the destination buffer and doesn't
unnecessarily NUL-pad.

While there is unlikely to be a buffer overread (or other related bug)
in this case, we should still favor a more robust and less ambiguous
interface.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/osi.c