vhost-user-blk: Make sure to set Error on realize failure
authorKevin Wolf <kwolf@redhat.com>
Thu, 29 Apr 2021 17:13:11 +0000 (19:13 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 18 May 2021 10:57:38 +0000 (12:57 +0200)
commitf26729715ef21325f972f693607580a829ad1cbb
treedae6d224bad97ab2ae01097dfd91fbd119d81f61
parent7999e3136d5f0ba474bc1b37e3799099e778f9ed
vhost-user-blk: Make sure to set Error on realize failure

We have to set errp before jumping to virtio_err, otherwise the caller
(virtio_device_realize()) will take this as success and crash when it
later tries to access things that we've already freed in the error path.

Fixes: 77542d431491788d1e8e79d93ce10172ef207775
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210429171316.162022-2-kwolf@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/block/vhost-user-blk.c