watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling
authorStefan Wahren <wahrenst@gmx.net>
Sun, 12 Nov 2023 17:32:51 +0000 (18:32 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 17 Dec 2023 15:14:22 +0000 (16:14 +0100)
commitf33f5b1fd1be5f5106d16f831309648cb0f1c31d
treef8626adaec041f34baa90c8edc657a750c73e4c0
parent91c437ea47045379db870fd0454d8778573b41e0
watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling

Users report about the unexpected behavior for setting timeouts above
15 sec on Raspberry Pi. According to watchdog-api.rst the ioctl
WDIOC_SETTIMEOUT shouldn't fail because of hardware limitations.
But looking at the code shows that max_timeout based on the
register value PM_WDOG_TIME_SET, which is the maximum.

Since 664a39236e71 ("watchdog: Introduce hardware maximum heartbeat
in watchdog core") the watchdog core is able to handle this problem.

This fix has been tested with watchdog-test from selftests.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217374
Fixes: 664a39236e71 ("watchdog: Introduce hardware maximum heartbeat in watchdog core")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231112173251.4827-1-wahrenst@gmx.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/bcm2835_wdt.c