9p: virtio: skip incrementing unused variable
authorDominique Martinet <asmadeus@codewreck.org>
Wed, 3 May 2023 07:49:28 +0000 (16:49 +0900)
committerEric Van Hensbergen <ericvh@kernel.org>
Thu, 20 Jul 2023 19:14:50 +0000 (19:14 +0000)
commitf41b402d2572e93bee85669ed05eb5e1f3725704
tree450f96bdf470dc2286005d929296e0a854c4991b
parent4a73edab69d3a6623f03817fe950a2d9585f80e4
9p: virtio: skip incrementing unused variable

Fix the following scan-build warning:
net/9p/trans_virtio.c:504:3: warning: Value stored to 'in' is never read [deadcode.DeadStores]
                in += pack_sg_list_p(chan->sg, out + in, VIRTQUEUE_NUM,
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm honestly not 100% sure about this one; I'm tempted to think we
could (should?) just check the return value of pack_sg_list_p to skip
the in_sgs++ and setting sgs[] if it didn't process anything, but I'm
not sure it should ever happen so this is probably fine as is.

Just removing the assignment at least makes it clear the return value
isn't used, so it's an improvement in terms of readability.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
net/9p/trans_virtio.c