Bluetooth: call sock_hold earlier in sco_conn_del
authorDesmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Fri, 3 Sep 2021 03:13:05 +0000 (23:13 -0400)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 3 Sep 2021 23:33:10 +0000 (16:33 -0700)
commitf4712fa993f688d0a48e0c28728fcdeb88c1ea58
tree6f30a1ac4fa8340bf868fe7111dac0b876399087
parent15957cab9db009c10925994b59a64410a707c17e
Bluetooth: call sock_hold earlier in sco_conn_del

In sco_conn_del, conn->sk is read while holding on to the
sco_conn.lock to avoid races with a socket that could be released
concurrently.

However, in between unlocking sco_conn.lock and calling sock_hold,
it's possible for the socket to be freed, which would cause a
use-after-free write when sock_hold is finally called.

To fix this, the reference count of the socket should be increased
while the sco_conn.lock is still held.

Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/sco.c