of: of_property_read_string return -ENODATA when !length
authorStefano Stabellini <stefano.stabellini@xilinx.com>
Sat, 16 Apr 2022 00:30:28 +0000 (17:30 -0700)
committerRob Herring <robh@kernel.org>
Tue, 19 Apr 2022 15:19:18 +0000 (10:19 -0500)
commitf688d61925f28699872307a66919bd164ba42ce0
treefdad356e03bea8032f313a427def756c31e452bb
parentf2701e0ffd2195a2610d14d289785513100d5dfd
of: of_property_read_string return -ENODATA when !length

When the length of the string is zero of_property_read_string should
return -ENODATA according to the description of the function.

However, of_property_read_string doesn't check prop->length. If
prop->length is zero, return -ENODATA.

Without this patch the following command in u-boot:

fdt set /chosen/node property-name

results in of_property_read_string returning -EILSEQ when attempting to
read property-name. With this patch, it returns -ENODATA as expected.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220416003028.1315268-1-sstabellini@kernel.org
drivers/of/property.c