powerpc/pseries: unregister VPA when hot unplugging a CPU
authorLaurent Dufour <ldufour@linux.ibm.com>
Mon, 14 Nov 2022 16:01:50 +0000 (17:01 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 7 Dec 2022 09:30:23 +0000 (20:30 +1100)
commitf6aa37c51ec0d053ee34c235bfe0e666618a3baf
tree43d503ae93b4787726bd29f7ce3fa7625886efa1
parent9b574cfab7d4e68c67c4ee4fcde912ef54a25b88
powerpc/pseries: unregister VPA when hot unplugging a CPU

The VPA should unregister when offlining a CPU. Otherwise there could be
a short window where 2 CPUs could share the same VPA.

This happens because the hypervisor is still keeping the VPA attached to
the vCPU even if it became offline.

Here is a potential situation:
 1. remove proc A,
 2. add proc B. If proc B gets proc A's place in cpu_present_mask, then
    it registers proc A's VPAs.
 3. If proc B is then re-added to the LP, its threads are sharing VPAs
    with proc A briefly as they come online.

As the hypervisor may check for the VPA's yield_count field oddity, it
may detect an unexpected value and kill the LPAR.

Suggested-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
[mpe: s/cpu_present_map/cpu_present_mask/ in change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221114160150.13554-1-ldufour@linux.ibm.com
arch/powerpc/platforms/pseries/hotplug-cpu.c