pinctrl: pinctrl-zynqmp: Use devm_kcalloc() instead of devm_kzalloc()
authorErick Archer <erick.archer@gmx.com>
Fri, 19 Jan 2024 18:19:09 +0000 (19:19 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 28 Jan 2024 00:17:26 +0000 (01:17 +0100)
commitf6f62a9a931f54607107196c029a8e0386591a71
treebb0df7f11805d206e16e0048225bb80f52ea5c8b
parent8714b3414dd6070609fabdd73a70e5f818f77f24
pinctrl: pinctrl-zynqmp: Use devm_kcalloc() instead of devm_kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific devm_kcalloc() function instead of the
argument size * count in the devm_kzalloc() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20240119181909.7079-1-erick.archer@gmx.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-zynqmp.c