HID: logitech-hidpp: Fix "Sw. Id." for HID++ 2.0 commands
authorBastien Nocera <hadess@hadess.net>
Tue, 30 Aug 2022 13:25:48 +0000 (15:25 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 7 Sep 2022 20:07:49 +0000 (22:07 +0200)
commitf7b7393cc3b04e288de85790b1c8e62af99799c2
tree9048f4b2c7ba29794552813e4aa77a38dc99c710
parent8544c812e43ab7bdf40458411b83987b8cba924d
HID: logitech-hidpp: Fix "Sw. Id." for HID++ 2.0 commands

Always set a non-zero "Sw. Id." in the lower nibble of the Function/ASE
and Software Identifier byte in HID++ 2.0 commands.

As per the "Protocol HID++2.0 essential features" section in
https://lekensteyn.nl/files/logitech/logitech_hidpp_2.0_specification_draft_2012-06-04.pdf
"
Software identifier (4 bits, unsigned)

A number uniquely defining the software that sends a request. The
firmware must copy the software identifier in the response but does
not use it in any other ways.

0 Do not use (allows to distinguish a notification from a response).
"

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215699
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c